Update dependencies from dotnet/roslyn #110105

am11 · 2024-11-23T15:11:50Z

Testing #110084 with build fixes.

…122.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24572.2

…122.15 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24572.15

dotnet-policy-service · 2024-11-23T15:12:31Z

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

...libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentStack.cs

…124.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24574.5

…125.18 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24575.18

…127.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24577.2

…128.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24578.2

…128.3 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24578.3

…130.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24580.1

…130.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24580.2

…201.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24601.2

…202.26 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24602.26

am11 · 2024-12-04T15:50:05Z

@dotnet/illink, @MichalStrehovsky, any thoughts about the last error under Build Analysis https://github.com/dotnet/runtime/pull/110105/checks?check_run_id=33908815428:

    ❌ Mono.Linker.Tests.TestCases.All.DataFlow(t: \"CompilerGeneratedCodeAccessedViaReflection\")
    Exception Message

        Unexpected warning found: ILC: Trim analysis warning IL2062: Mono.Linker.Tests.Cases.DataFlow.CompilerGeneratedCodeAccessedViaReflection.IteratorStateMachines.<IteratorWithIntegerDataflow>d__3.MoveNext(): Value passed to parameter 'type' of method 'Mono.Linker.Tests.Cases.Expectations.Helpers.DataFlowTypeExtensions.RequiresPublicMethods(Type)' can not be statically determined and may not meet 'DynamicallyAccessedMembersAttribute' requirements.

    Stack Trace

           at Mono.Linker.Tests.TestCasesRunner.ResultChecker.VerifyLoggedMessages(AssemblyDefinition original, TrimmingTestLogger logger, Boolean checkRemainingErrors) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 405
           at Mono.Linker.Tests.TestCasesRunner.ResultChecker.AdditionalChecking(TrimmedTestCaseResult linkResult, AssemblyDefinition original) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 157
           at Mono.Linker.Tests.TestCasesRunner.ResultChecker.Check(TrimmedTestCaseResult testResult) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCasesRunner/ResultChecker.cs:line 70
           at Mono.Linker.Tests.TestCases.All.Run(String testName) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCases/TestSuites.cs:line 157
           at Mono.Linker.Tests.TestCases.All.DataFlow(String t) in /_/src/coreclr/tools/aot/ILCompiler.Trimming.Tests/TestCases/TestSuites.cs:line 16
           at InvokeStub_All.DataFlow(Object, Span`1)
           at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

With this roslyn update, the generated iterator state machine for this test includes a Dispose method which assigns null to the array, inhibiting dataflow analysis.

am11 · 2024-12-10T09:44:23Z

Thanks @sbomer for pushing the fix!

am11 · 2024-12-12T11:15:29Z

@akoeplinger @ViktorHofer PTAL.

* Update dependencies from https://github.com/dotnet/roslyn build 20241122.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24572.2 * Update dependencies from https://github.com/dotnet/roslyn build 20241122.15 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24572.15 * Update dependencies from https://github.com/dotnet/roslyn build 20241124.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24574.5 * Update dependencies from https://github.com/dotnet/roslyn build 20241125.18 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24575.18 * Update dependencies from https://github.com/dotnet/roslyn build 20241127.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24577.2 * Update dependencies from https://github.com/dotnet/roslyn build 20241128.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24578.2 * Update dependencies from https://github.com/dotnet/roslyn build 20241128.3 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24578.3 * Update dependencies from https://github.com/dotnet/roslyn build 20241130.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24580.1 * Update dependencies from https://github.com/dotnet/roslyn build 20241130.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24580.2 * Update dependencies from https://github.com/dotnet/roslyn build 20241201.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24601.2 * Update dependencies from https://github.com/dotnet/roslyn build 20241202.26 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24602.26 * Use explicit AsSpan * Fix LibraryImportGenerator.UnitTests * Fix regex tests * Adjust trimming test for new codegen With this roslyn update, the generated iterator state machine for this test includes a Dispose method which assigns null to the array, inhibiting dataflow analysis. --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Sven Boemer <[email protected]>

dotnet-maestro bot added 2 commits November 22, 2024 13:09

Update dependencies from https://github.com/dotnet/roslyn build 20241…

8cf386f

…122.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24572.2

Update dependencies from https://github.com/dotnet/roslyn build 20241…

ae6fee2

…122.15 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24572.15

am11 requested a review from MichalStrehovsky as a code owner November 23, 2024 15:11

dotnet-issue-labeler bot added the area-Meta label Nov 23, 2024

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 23, 2024

am11 commented Nov 23, 2024

View reviewed changes

...libraries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentStack.cs Outdated Show resolved Hide resolved

dotnet-maestro bot added 2 commits November 24, 2024 13:35

Update dependencies from https://github.com/dotnet/roslyn build 20241…

2a13a6f

…124.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24574.5

Update dependencies from https://github.com/dotnet/roslyn build 20241…

ba99bdf

…125.18 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24575.18

jcouv mentioned this pull request Nov 26, 2024

Enumerators incorrectly allow continued enumerator after disposal dotnet/roslyn#76078

Closed

dotnet-maestro bot added 2 commits November 27, 2024 13:41

Update dependencies from https://github.com/dotnet/roslyn build 20241…

96ae4f3

…127.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24577.2

Update dependencies from https://github.com/dotnet/roslyn build 20241…

f6364ee

…128.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24578.2

akoeplinger mentioned this pull request Nov 28, 2024

[main] Update dependencies from dotnet/roslyn #110084

Merged

dotnet-maestro bot added 5 commits November 29, 2024 13:36

Update dependencies from https://github.com/dotnet/roslyn build 20241…

089fcd0

…128.3 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24578.3

Update dependencies from https://github.com/dotnet/roslyn build 20241…

535c884

…130.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24580.1

Update dependencies from https://github.com/dotnet/roslyn build 20241…

2e73b10

…130.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24580.2

Update dependencies from https://github.com/dotnet/roslyn build 20241…

68215e4

…201.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24601.2

Update dependencies from https://github.com/dotnet/roslyn build 20241…

edd325f

…202.26 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24602.26

am11 force-pushed the darc-main-19369168-1f4a-490d-90eb-b9e754971a1a branch 5 times, most recently from f47afb0 to 3a7a63b Compare December 3, 2024 15:02

build-analysis bot mentioned this pull request Dec 3, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

This was referenced Dec 3, 2024

iOS tests failing with WORKLOAD TIMED OUT - Killing user command. #108103

Open

System.Formats.Nrbf.Tests timeouts #110285

Closed

Use explicit AsSpan

d84efa9

am11 force-pushed the darc-main-19369168-1f4a-490d-90eb-b9e754971a1a branch from ece3176 to d84efa9 Compare December 4, 2024 02:51

am11 added 2 commits December 4, 2024 04:55

Merge branch 'main' into darc-main-19369168-1f4a-490d-90eb-b9e754971a1a

fe444d6

Fix LibraryImportGenerator.UnitTests

0b69315

build-analysis bot mentioned this pull request Dec 4, 2024

The hosted runner encountered an error while running your job. (Error Type: Disconnect). dotnet/dnceng#1919

Open

3 tasks

Fix regex tests

2879dab

build-analysis bot mentioned this pull request Dec 4, 2024

[mono] Runtime tests LargeStructSize_Mono and xprecise1_cs_do failing on Apple mobile #110149

Closed

sbomer mentioned this pull request Dec 9, 2024

Trim analysis fails to track integer across iterator yield #110553

Open

Adjust trimming test for new codegen

a2a1b52

With this roslyn update, the generated iterator state machine for this test includes a Dispose method which assigns null to the array, inhibiting dataflow analysis.

sbomer requested a review from marek-safar as a code owner December 9, 2024 23:28

Merge branch 'main' into darc-main-19369168-1f4a-490d-90eb-b9e754971a1a

263d5eb

am11 requested review from akoeplinger and jjonescz December 10, 2024 09:44

jjonescz approved these changes Dec 10, 2024

View reviewed changes

ViktorHofer approved these changes Dec 12, 2024

View reviewed changes

ViktorHofer merged commit dfb2b8a into dotnet:main Dec 12, 2024
157 of 159 checks passed

am11 deleted the darc-main-19369168-1f4a-490d-90eb-b9e754971a1a branch December 12, 2024 11:28

LoopedBard3 mentioned this pull request Dec 17, 2024

[Perf] Linux/x64: 5 Regressions on 12/12/2024 1:14:47 PM #110788

Open

github-actions bot mentioned this pull request Dec 17, 2024

110105 MichalStrehovsky/rt-sz#92

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies from dotnet/roslyn #110105

Update dependencies from dotnet/roslyn #110105

am11 commented Nov 23, 2024

dotnet-policy-service bot commented Nov 23, 2024

am11 commented Dec 4, 2024

am11 commented Dec 10, 2024

am11 commented Dec 12, 2024

Update dependencies from dotnet/roslyn #110105

Update dependencies from dotnet/roslyn #110105

Conversation

am11 commented Nov 23, 2024

dotnet-policy-service bot commented Nov 23, 2024

am11 commented Dec 4, 2024

am11 commented Dec 10, 2024

am11 commented Dec 12, 2024